Skip to content

feat: add tracing to cbv#12896

Merged
wkrozowski merged 2 commits intoleanprover:masterfrom
wkrozowski:wojciech/cbv_traces
Mar 13, 2026
Merged

feat: add tracing to cbv#12896
wkrozowski merged 2 commits intoleanprover:masterfrom
wkrozowski:wojciech/cbv_traces

Conversation

@wkrozowski
Copy link
Copy Markdown
Contributor

This PR adds a basic tracing infrastructure to cbv tactic.

@wkrozowski wkrozowski added the changelog-no Do not include this PR in the release changelog label Mar 12, 2026
@github-actions github-actions bot added the toolchain-available A toolchain is available for this PR, at leanprover/lean4-pr-releases:pr-release-NNNN label Mar 12, 2026
@mathlib-lean-pr-testing
Copy link
Copy Markdown

Mathlib CI status (docs):

  • ❗ Batteries/Mathlib CI will not be attempted unless your PR branches off the nightly-with-mathlib branch. Try git rebase 47833725eaded4cec8cc7944ab656eaf05208da7 --onto e8048291010c815d0d30926924e7ad7afc18b1c0. You can force Mathlib CI using the force-mathlib-ci label. (2026-03-12 16:13:52)

@leanprover-bot
Copy link
Copy Markdown
Collaborator

Reference manual CI status:

  • ❗ Reference manual CI will not be attempted unless your PR branches off the nightly-with-manual branch. Try git rebase 47833725eaded4cec8cc7944ab656eaf05208da7 --onto 24acf2b895670fdeeafc64c4f606e7a0ebc19e6d. You can force reference manual CI using the force-manual-ci label. (2026-03-12 16:13:54)

@wkrozowski wkrozowski marked this pull request as ready for review March 12, 2026 18:20
@wkrozowski wkrozowski requested a review from leodemoura as a code owner March 12, 2026 18:20
@wkrozowski
Copy link
Copy Markdown
Contributor Author

!bench

@leanprover-radar
Copy link
Copy Markdown

leanprover-radar commented Mar 12, 2026

Benchmark results for b70eb93 against 4783372 are in. There are no significant changes. @wkrozowski

  • 🟥 build//instructions: +9.0G (+0.07%)

Small changes (4🟥)

  • 🟥 build/module/Lean.Meta.Tactic.Cbv.CbvSimproc//instructions: +752.6M (+15.53%) (reduced significance based on *//lines)
  • 🟥 build/module/Lean.Meta.Tactic.Cbv.ControlFlow//instructions: +661.5M (+10.42%) (reduced significance based on *//lines)
  • 🟥 build/module/Lean.Meta.Tactic.Cbv.Main//instructions: +7.4G (+128.95%) (reduced significance based on *//lines)
  • 🟥 build/module/Lean.Meta.Tactic.Cbv//instructions: +141.1M (+21.77%) (reduced significance based on *//lines)

@wkrozowski wkrozowski added this pull request to the merge queue Mar 13, 2026
Merged via the queue into leanprover:master with commit a32173e Mar 13, 2026
24 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

changelog-no Do not include this PR in the release changelog toolchain-available A toolchain is available for this PR, at leanprover/lean4-pr-releases:pr-release-NNNN

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants