fix: use process signal numbers from correct architecture#12900
Merged
fix: use process signal numbers from correct architecture#12900
Conversation
6699672 to
18bf81a
Compare
|
Mathlib CI status (docs):
|
Collaborator
|
Reference manual CI status:
|
Member
|
Maybe we should remove the def main : IO Unit := Async.block do
let waiter ← Signal.Waiter.mk .sigusr1 false
IO.println "Waiting for SIGUSR1..."
discard <| await (← waiter.wait)
IO.println "Received SIGUSR1!"In macOS the master branch captures the signal, in your branch it just kills the process. |
This PR fixes some process signals that were incorrectly numbered.
18bf81a to
5713082
Compare
Contributor
Author
|
Would something like this work? I don't have a mac to test against. |
algebraic-dev
approved these changes
Mar 16, 2026
Member
|
It works on macOS now. |
Contributor
Author
|
I think the test is flaky when other tests are running in parallel |
f0e2251 to
f011392
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR fixes some process signals that were incorrectly numbered.
From what I can tell, the code used signals and signal numbers for Alpha/SPARC, not x86/ARM. The test was also broken and always green, hiding the mistake.