fix: make cbv_opaque take precedence over cbv_eval#12908
Merged
wkrozowski merged 1 commit intoleanprover:masterfrom Mar 13, 2026
Merged
fix: make cbv_opaque take precedence over cbv_eval#12908wkrozowski merged 1 commit intoleanprover:masterfrom
cbv_opaque take precedence over cbv_eval#12908wkrozowski merged 1 commit intoleanprover:masterfrom
Conversation
Contributor
Author
|
!bench |
|
Benchmark results for 00a809e against a32173e are in. There are no significant changes. @wkrozowski
Small changes (1✅, 1🟥)
|
|
Mathlib CI status (docs):
|
Collaborator
|
Reference manual CI status:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR makes
@[cbv_opaque]unconditionally block all evaluation of a constantby
cbv, including@[cbv_eval]rewrite rules. Previously,@[cbv_eval]couldbypass
@[cbv_opaque], and for bare constants (not applications),isOpaqueConstcould fall through to
handleConstwhich would unfold the definition body.The intended usage pattern is now: mark subterm-producing functions (like
DHashMap.insert) as@[cbv_opaque]to prevent unfolding, and provide@[cbv_eval]theorems on the consuming function (likeDHashMap.contains)which pattern-matches against the opaque subterms.