fix: correct swapped operands in Std.Time subtraction instances#12919
Merged
TwoFX merged 1 commit intoleanprover:masterfrom Mar 16, 2026
Merged
fix: correct swapped operands in Std.Time subtraction instances#12919TwoFX merged 1 commit intoleanprover:masterfrom
TwoFX merged 1 commit intoleanprover:masterfrom
Conversation
005007a to
904b3d7
Compare
|
Mathlib CI status (docs):
|
Collaborator
|
Reference manual CI status:
|
904b3d7 to
c1f1da6
Compare
mathlib-nightly-testing bot
pushed a commit
to leanprover-community/batteries
that referenced
this pull request
Mar 14, 2026
mathlib-nightly-testing bot
pushed a commit
to leanprover-community/mathlib4-nightly-testing
that referenced
this pull request
Mar 14, 2026
|
Mathlib CI status (docs):
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR fixes the
HSub PlainTime Durationinstance, which had its operands reversed: it computedduration - timeinstead oftime - duration. For example, subtracting 2 minutes fromtime("13:02:01")would givetime("10:57:59")rather than the expectedtime("13:00:01"). We also noticed thatHSub PlainDateTime Millisecond.Offsetis similarly affected.Closes #12918