fix: eta-reduce expressions in sym discrimination tree lookup#12920
Merged
leodemoura merged 1 commit intomasterfrom Mar 14, 2026
Merged
fix: eta-reduce expressions in sym discrimination tree lookup#12920leodemoura merged 1 commit intomasterfrom
leodemoura merged 1 commit intomasterfrom
Conversation
Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR adds eta reduction to the sym discrimination tree lookup functions (
getMatch,getMatchWithExtra,getMatchLoop). Without this, expressions likeStateM Natthat unfold to eta-expanded forms(fun α => StateT Nat Id α)fail to match discrimination tree entries for the eta-reduced form(StateT Nat Id).Also optimizes
etaReducewith an early exit for non-lambda expressions and removes a redundantn == 0check.Includes a test verifying that
P (StateM Nat)matches a disc tree entry forP (StateT Nat Id).