perf: mark ReaderT context argument as borrow#12942
Conversation
d29bfab to
b88612d
Compare
|
Mathlib CI status (docs):
|
|
Reference manual CI status:
|
b88612d to
53c7dc9
Compare
53c7dc9 to
4771717
Compare
4771717 to
1fdf271
Compare
|
!bench |
|
Benchmark results for 1fdf271 against 511be30 are in. Significant changes detected! @hargoniX
Large changes (4✅)
Medium changes (15✅)
and 1 hidden Small changes (1201✅) Too many entries to display here. View the full report on radar instead. |
ad286ae to
6d31ce7
Compare
|
!bench |
f57c1c6 to
d34f8f2
Compare
|
Benchmark results for d34f8f2 against 4a62d4a are in. Significant changes detected! @hargoniX
Large changes (9✅)
Medium changes (29✅) Too many entries to display here. View the full report on radar instead. Small changes (1118✅, 6🟥) Too many entries to display here. View the full report on radar instead. |
fix more tests
|
!bench |
d34f8f2 to
dfe88e1
Compare
|
Benchmark results for dfe88e1 against 47427f8 are in. Significant changes detected! @hargoniX
Large changes (9✅)
Medium changes (29✅) Too many entries to display here. View the full report on radar instead. Small changes (1127✅, 4🟥) Too many entries to display here. View the full report on radar instead. |
dfe88e1 to
97bd7cc
Compare
97bd7cc to
99baacc
Compare
99baacc to
bddc156
Compare
This PR marks the context argument of
ReaderTas borrowed, causing a wide spread of useful borrow annotations throughout the entire meta stack which reduces RC pressure. This introduces a crucial new behavior: When modifyingReaderTcontext, e.g. throughwithReaderthis will almost always cause an allocation. Given that theReaderTcontext is frequently used in a non-linear fashion anyways we think this is an acceptable behavior.