feat: allow @[cbv_eval] to override @[cbv_opaque]#12944
Merged
wkrozowski merged 1 commit intoleanprover:masterfrom Mar 17, 2026
Merged
feat: allow @[cbv_eval] to override @[cbv_opaque]#12944wkrozowski merged 1 commit intoleanprover:masterfrom
@[cbv_eval] to override @[cbv_opaque]#12944wkrozowski merged 1 commit intoleanprover:masterfrom
Conversation
This PR changes the interaction between `@[cbv_opaque]` and `@[cbv_eval]` attributes in the `cbv` tactic. Previously, `@[cbv_opaque]` completely blocked all reduction including `@[cbv_eval]` rewrite rules. Now, `@[cbv_eval]` rules can fire on `@[cbv_opaque]` constants, allowing users to provide custom rewrite rules without exposing the full definition. Equation theorems, unfold theorems, and kernel reduction remain suppressed for opaque constants. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
Collaborator
|
Reference manual CI status:
|
mathlib-nightly-testing bot
pushed a commit
to leanprover-community/batteries
that referenced
this pull request
Mar 17, 2026
mathlib-nightly-testing bot
pushed a commit
to leanprover-community/mathlib4-nightly-testing
that referenced
this pull request
Mar 17, 2026
|
Mathlib CI status (docs):
|
wkrozowski
added a commit
to leanprover/reference-manual
that referenced
this pull request
Mar 17, 2026
…que` attributes (#808) This PR changes the description of interaction of `cbv_eval` and `cbv_opaque` attributes, to reflect leanprover/lean4#12944.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR changes the interaction between
@[cbv_opaque]and@[cbv_eval]attributes in the
cbvtactic. Previously,@[cbv_opaque]completely blockedall reduction including
@[cbv_eval]rewrite rules. Now,@[cbv_eval]rulescan fire on
@[cbv_opaque]constants, allowing users to provide custom rewriterules without exposing the full definition. Equation theorems, unfold theorems,
and kernel reduction remain suppressed for opaque constants.
🤖 Generated with Claude Code