feat: add simp lemmas for kernel-friendly functions#12950
Merged
TwoFX merged 1 commit intoleanprover:masterfrom Mar 18, 2026
Merged
feat: add simp lemmas for kernel-friendly functions#12950TwoFX merged 1 commit intoleanprover:masterfrom
TwoFX merged 1 commit intoleanprover:masterfrom
Conversation
This PR adds simp lemmas equating kernel-friendly function names with their operator notation equivalents: `Nat.land_eq`, `Nat.lor_eq`, `Nat.xor_eq`, `Nat.shiftLeft_eq'`, `Nat.shiftRight_eq'`, and `Bool.rec_eq`. These are useful when proofs involve reflection and need to simplify kernel-reduced terms back to operator notation. Closes leanprover#12716 Co-authored-by: Claude <noreply@anthropic.com>
Contributor
Author
|
changelog-library |
nomeata
reviewed
Mar 17, 2026
Collaborator
nomeata
left a comment
nomeata
left a comment
There was a problem hiding this comment.
Looks plausible, but it raises questions about the desired simp normal form, so needs careful review by the stdlib team.
Contributor
Author
My understanding is that each of the Nat-specific ones are not meant to be used directly, see eg the docs of Nat.lor (and indeed all of the ones I've now made simp away) |
github-actions
bot
added
the
toolchain-available
|
Mathlib CI status (docs):
|
Collaborator
|
Reference manual CI status:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR adds simp lemmas equating kernel-friendly function names with their operator notation equivalents:
Nat.land_eq,Nat.lor_eq,Nat.xor_eq,Nat.shiftLeft_eq',Nat.shiftRight_eq', andBool.rec_eq. These are useful when proofs involve reflection and need to simplify kernel-reduced terms back to operator notation.Closes #12716