Skip to content

fix: prevent induction/cases from swallowing diagnostics when using clause contains by#12953

Merged
Kha merged 1 commit intoleanprover:masterfrom
Kha:push-ypkqtlpxvoqx
Mar 19, 2026
Merged

fix: prevent induction/cases from swallowing diagnostics when using clause contains by#12953
Kha merged 1 commit intoleanprover:masterfrom
Kha:push-ypkqtlpxvoqx

Conversation

@Kha
Copy link
Copy Markdown
Member

@Kha Kha commented Mar 17, 2026

This PR fixes an issue where the induction and cases tactics would swallow diagnostics (such as unsolved goals errors) when the using clause contains a nested tactic.

Closes #12815

@Kha Kha requested a review from kim-em as a code owner March 17, 2026 17:28
@Kha Kha enabled auto-merge March 17, 2026 17:28
@github-actions github-actions bot added the toolchain-available A toolchain is available for this PR, at leanprover/lean4-pr-releases:pr-release-NNNN label Mar 17, 2026
@mathlib-lean-pr-testing
Copy link
Copy Markdown

mathlib-lean-pr-testing bot commented Mar 17, 2026

Mathlib CI status (docs):

  • ❗ Batteries/Mathlib CI will not be attempted unless your PR branches off the nightly-with-mathlib branch. Try git rebase e2b500b204cacbb3149f42feda880c8bdfcab7db --onto 6714601ee4a123fef0f6ff3e44f01086ba78dfce. You can force Mathlib CI using the force-mathlib-ci label. (2026-03-17 18:34:35)
  • ❗ Batteries/Mathlib CI will not be attempted unless your PR branches off the nightly-with-mathlib branch. Try git rebase e2b500b204cacbb3149f42feda880c8bdfcab7db --onto 61a3443a9569d548a235f785b9a33984bb7ff622. You can force Mathlib CI using the force-mathlib-ci label. (2026-03-18 10:46:39)

@leanprover-bot
Copy link
Copy Markdown
Collaborator

Reference manual CI status:

  • ❗ Reference manual CI will not be attempted unless your PR branches off the nightly-with-manual branch. Try git rebase e2b500b204cacbb3149f42feda880c8bdfcab7db --onto cfa8c5a036d6990635c6ec50b02d0e806995cec3. You can force reference manual CI using the force-manual-ci label. (2026-03-17 18:34:37)

@Kha Kha force-pushed the push-ypkqtlpxvoqx branch from 45c9ce4 to 14b92ec Compare March 18, 2026 09:41
@Kha Kha requested a review from leodemoura as a code owner March 18, 2026 09:41
@Kha Kha added the changelog-language Language features and metaprograms label Mar 19, 2026
@Kha Kha added this pull request to the merge queue Mar 19, 2026
Merged via the queue into leanprover:master with commit d9c3bbf Mar 19, 2026
22 of 23 checks passed
@Kha Kha deleted the push-ypkqtlpxvoqx branch March 20, 2026 11:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

changelog-language Language features and metaprograms toolchain-available A toolchain is available for this PR, at leanprover/lean4-pr-releases:pr-release-NNNN

Projects

None yet

Development

Successfully merging this pull request may close these issues.

induction tactic swallows IDE diagnostics

2 participants