Skip to content

fix: shake: avoid panic on header-only files without trailing newline#12963

Merged
Kha merged 1 commit intoleanprover:masterfrom
Kha:push-uzxsllrmxulq
Mar 18, 2026
Merged

fix: shake: avoid panic on header-only files without trailing newline#12963
Kha merged 1 commit intoleanprover:masterfrom
Kha:push-uzxsllrmxulq

Conversation

@Kha
Copy link
Copy Markdown
Member

@Kha Kha commented Mar 18, 2026

This PR fixes a panic in lake shake when applied to a header-only file without trailing newline

@Kha Kha requested a review from tydeu as a code owner March 18, 2026 10:54
@github-actions github-actions bot added the toolchain-available A toolchain is available for this PR, at leanprover/lean4-pr-releases:pr-release-NNNN label Mar 18, 2026
@leanprover-bot
Copy link
Copy Markdown
Collaborator

Reference manual CI status:

  • ❗ Reference manual CI can not be attempted yet, as the nightly-testing-2026-03-17 tag does not exist there yet. We will retry when you push more commits. If you rebase your branch onto nightly-with-manual, reference manual CI should run now. You can force reference manual CI using the force-manual-ci label. (2026-03-18 11:47:48)

mathlib-nightly-testing bot pushed a commit to leanprover-community/batteries that referenced this pull request Mar 18, 2026
@github-actions github-actions bot added the mathlib4-nightly-available A branch for this PR exists at leanprover-community/mathlib4-nightly-testing:lean-pr-testing-NNNN label Mar 18, 2026
mathlib-nightly-testing bot pushed a commit to leanprover-community/mathlib4-nightly-testing that referenced this pull request Mar 18, 2026
@mathlib-lean-pr-testing mathlib-lean-pr-testing bot added the builds-mathlib CI has verified that Mathlib builds against this PR label Mar 18, 2026
@mathlib-lean-pr-testing
Copy link
Copy Markdown

Mathlib CI status (docs):

@Kha Kha enabled auto-merge March 18, 2026 15:44
@Kha Kha added this pull request to the merge queue Mar 18, 2026
Merged via the queue into leanprover:master with commit b13325f Mar 18, 2026
29 of 32 checks passed
@Kha Kha deleted the push-uzxsllrmxulq branch March 19, 2026 10:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

builds-mathlib CI has verified that Mathlib builds against this PR changelog-other mathlib4-nightly-available A branch for this PR exists at leanprover-community/mathlib4-nightly-testing:lean-pr-testing-NNNN toolchain-available A toolchain is available for this PR, at leanprover/lean4-pr-releases:pr-release-NNNN

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants