Skip to content

perf: remove simp annotations#12977

Merged
TwoFX merged 1 commit intoleanprover:masterfrom
TwoFX:logic-simp-lemmas-perf-2
Mar 19, 2026
Merged

perf: remove simp annotations#12977
TwoFX merged 1 commit intoleanprover:masterfrom
TwoFX:logic-simp-lemmas-perf-2

Conversation

@TwoFX
Copy link
Copy Markdown
Member

@TwoFX TwoFX commented Mar 19, 2026

This PR removes most of the simp annotations added in #12945, to mitigate the performance impact. The lemmas remain.

@TwoFX TwoFX requested a review from kim-em as a code owner March 19, 2026 07:38
@TwoFX TwoFX added the changelog-library Library label Mar 19, 2026
@TwoFX
Copy link
Copy Markdown
Member Author

TwoFX commented Mar 19, 2026

!radar

@leanprover-radar
Copy link
Copy Markdown

leanprover-radar commented Mar 19, 2026

Benchmark results for 9112376 against 61a3443 are in. Significant changes detected! @TwoFX

  • build//instructions: -29.8G (-0.24%)

Medium changes (6✅)

  • build/module/Init.Data.Array.Attach//instructions: -1.6G (-11.85%) (reduced significance based on absolute threshold)
  • build/module/Init.Data.Int.Linear//instructions: -1.5G (-4.68%)
  • build/module/Init.Data.List.Find//instructions: -1.2G (-4.91%) (reduced significance based on absolute threshold)
  • build/module/Init.Data.Range.Polymorphic.Lemmas//instructions: -2.6G (-4.73%) (reduced significance based on absolute threshold)
  • build/module/Init.Data.Vector.Lemmas//instructions: -1.2G (-2.27%) (reduced significance based on absolute threshold)
  • misc/import Init.Data.List.Sublist//instructions: -133.6M (-1.22%)

Small changes (108✅)

Too many entries to display here. View the full report on radar instead.

@TwoFX TwoFX added this pull request to the merge queue Mar 19, 2026
Merged via the queue into leanprover:master with commit a045a7c Mar 19, 2026
21 checks passed
@github-actions github-actions bot added the toolchain-available A toolchain is available for this PR, at leanprover/lean4-pr-releases:pr-release-NNNN label Mar 19, 2026
@leanprover-bot
Copy link
Copy Markdown
Collaborator

Reference manual CI status:

  • ❗ Reference manual CI can not be attempted yet, as the nightly-testing-2026-03-18 tag does not exist there yet. We will retry when you push more commits. If you rebase your branch onto nightly-with-manual, reference manual CI should run now. You can force reference manual CI using the force-manual-ci label. (2026-03-19 08:27:40)

mathlib-nightly-testing bot pushed a commit to leanprover-community/batteries that referenced this pull request Mar 19, 2026
@github-actions github-actions bot added the mathlib4-nightly-available A branch for this PR exists at leanprover-community/mathlib4-nightly-testing:lean-pr-testing-NNNN label Mar 19, 2026
mathlib-nightly-testing bot pushed a commit to leanprover-community/mathlib4-nightly-testing that referenced this pull request Mar 19, 2026
@mathlib-lean-pr-testing mathlib-lean-pr-testing bot added the breaks-mathlib This is not necessarily a blocker for merging: but there needs to be a plan label Mar 19, 2026
@mathlib-lean-pr-testing
Copy link
Copy Markdown

Mathlib CI status (docs):

@mathlib-lean-pr-testing mathlib-lean-pr-testing bot added builds-mathlib CI has verified that Mathlib builds against this PR and removed breaks-mathlib This is not necessarily a blocker for merging: but there needs to be a plan labels Mar 19, 2026
@mathlib-lean-pr-testing
Copy link
Copy Markdown

Mathlib CI status (docs):

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

builds-mathlib CI has verified that Mathlib builds against this PR changelog-library Library mathlib4-nightly-available A branch for this PR exists at leanprover-community/mathlib4-nightly-testing:lean-pr-testing-NNNN toolchain-available A toolchain is available for this PR, at leanprover/lean4-pr-releases:pr-release-NNNN

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants