Skip to content

fix: interaction between cbv_opaque and inline#12981

Merged
wkrozowski merged 1 commit intoleanprover:masterfrom
wkrozowski:wojciech/cbv_opaque_inline
Mar 19, 2026
Merged

fix: interaction between cbv_opaque and inline#12981
wkrozowski merged 1 commit intoleanprover:masterfrom
wkrozowski:wojciech/cbv_opaque_inline

Conversation

@wkrozowski
Copy link
Contributor

This PR fixes the interaction between cbv_opaque and inline/always_inline annotations, to make sure that inlined definitions marked as cbv_opaque are not unfolded during the preprocessing stage of cbv tactic.

@wkrozowski wkrozowski added the changelog-no Do not include this PR in the release changelog label Mar 19, 2026
@wkrozowski
Copy link
Contributor Author

!bench

@leanprover-radar
Copy link

leanprover-radar commented Mar 19, 2026

Benchmark results for d54e103 against 4ba85ac are in. There are no significant changes. @wkrozowski

  • 🟥 build//instructions: +1.3G (+0.01%)

Small changes (3🟥)

  • 🟥 build/module/Lean.Meta.Tactic.Cbv.Main//instructions: +1.7G (+12.73%) (reduced significance based on *//lines)
  • 🟥 lake/inundation/config tree//task-clock: +12ms (+8.15%)
  • 🟥 lake/inundation/config tree//wall-clock: +13ms (+8.32%)

@wkrozowski wkrozowski marked this pull request as ready for review March 19, 2026 11:23
@wkrozowski wkrozowski requested a review from leodemoura as a code owner March 19, 2026 11:23
@wkrozowski wkrozowski enabled auto-merge March 19, 2026 11:23
@wkrozowski wkrozowski added this pull request to the merge queue Mar 19, 2026
@github-actions github-actions bot added the toolchain-available A toolchain is available for this PR, at leanprover/lean4-pr-releases:pr-release-NNNN label Mar 19, 2026
@mathlib-lean-pr-testing
Copy link

Mathlib CI status (docs):

  • ❗ Batteries/Mathlib CI will not be attempted unless your PR branches off the nightly-with-mathlib branch. Try git rebase 4ba85acc464e380c03034763e93506f695ae68d7 --onto 61a3443a9569d548a235f785b9a33984bb7ff622. You can force Mathlib CI using the force-mathlib-ci label. (2026-03-19 11:39:27)

@leanprover-bot
Copy link
Collaborator

Reference manual CI status:

  • ❗ Reference manual CI will not be attempted unless your PR branches off the nightly-with-manual branch. Try git rebase 4ba85acc464e380c03034763e93506f695ae68d7 --onto cfa8c5a036d6990635c6ec50b02d0e806995cec3. You can force reference manual CI using the force-manual-ci label. (2026-03-19 11:39:29)

Merged via the queue into leanprover:master with commit 8f6ade0 Mar 19, 2026
24 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

changelog-no Do not include this PR in the release changelog toolchain-available A toolchain is available for this PR, at leanprover/lean4-pr-releases:pr-release-NNNN

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants