feat: stricter meta check for temporary programs in native_decide etc#13005
Merged
Kha merged 8 commits intoleanprover:masterfrom Mar 20, 2026
Merged
feat: stricter meta check for temporary programs in native_decide etc#13005Kha merged 8 commits intoleanprover:masterfrom
native_decide etc#13005Kha merged 8 commits intoleanprover:masterfrom
Conversation
Kha
added
awaiting-mathlib
Kha
requested review from
digama0,
hargoniX,
kim-em,
kmill,
leodemoura,
mhuisi and
tydeu
as code owners
github-actions
bot
added
the
toolchain-available
Collaborator
|
Reference manual CI status:
|
mathlib-nightly-testing bot
pushed a commit
to leanprover-community/batteries
that referenced
this pull request
Mar 20, 2026
github-actions
bot
added
the
mathlib4-nightly-available
mathlib-nightly-testing bot
pushed a commit
to leanprover-community/mathlib4-nightly-testing
that referenced
this pull request
Mar 20, 2026
mathlib-lean-pr-testing
bot
added
the
breaks-mathlib
|
mathlib-nightly-testing bot
pushed a commit
to leanprover-community/batteries
that referenced
this pull request
Mar 20, 2026
mathlib-nightly-testing bot
pushed a commit
to leanprover-community/mathlib4-nightly-testing
that referenced
this pull request
Mar 20, 2026
|
Kha
changed the title
native_decide etc.native_decide etc.
Kha
removed
the
awaiting-mathlib
Kha
changed the title
native_decide etc.native_decide etc
mathlib-lean-pr-testing
bot
added
builds-mathlib
|
Mathlib CI status (docs):
|
kim-em
added a commit
that referenced
this pull request
Apr 8, 2026
This PR fixes `include_str` failing with "Invalid `meta` definition `_tmp✝`, `System.FilePath.mk` is not accessible here" since stricter meta checks were introduced in #13005. The builtin `include_str` elaborator uses `evalTerm` to evaluate file path expressions, which internally constructs `System.FilePath` values. Since #13005 enforces meta accessibility for all constants referenced by compile-time evaluated definitions, `System.FilePath.mk` needs to be meta-accessible, requiring users to add `public meta import Init.System.FilePath`. The fix adds a `checkMeta` parameter to `evalTerm` (threading through to `evalExprCore`) so that builtin elaborators can opt out of meta checking when evaluating internal helper expressions. When `checkMeta := false`: - The temporary evaluation definition is not marked as meta - The compiler's meta check is fully disabled (not just relaxed) - The runtime meta check in `evalConst` is skipped Closes #13310 Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR further enforces that all modules used in compile-time execution must be meta imported in preparation for enabling #10291
Breaking changes
Metaprograms that call
compileDecldirectly may now need to callmarkMetafirst where appropriate, possibly based on the value ofisMarkedMetaof existing decls.addAndCompileshould be split intoaddDeclandcompileDeclfor this in order to insert the call in between.