feat: add Sym.simp theorem set attributes#13018
Merged
leodemoura merged 2 commits intomasterfrom Mar 21, 2026
Merged
Conversation
Add `register_sym_simp_attr` command for creating named Sym.simp theorem sets with associated attributes. Each set gets its own `SymSimpExtension` (persistent environment extension). When a proposition is tagged, it is added as a rewrite theorem. When a definition is tagged, its equation theorems are added. New files: - `Sym/Simp/Attr.lean`: `mkSymSimpAttr`, `registerSymSimpAttr` - `Sym/Simp/RegisterCommand.lean`: `register_sym_simp_attr` macro - `tests/pkg/sym_simp_attr/`: package test exercising the attribute
leodemoura
added
changelog-language
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR adds named theorem sets for
Sym.simpwith associated attributes, following the same pattern asMeta.simp'sregister_simp_attr.register_sym_simp_attr my_setcreates a named set with its ownPersistentEnvExtensionand attribute@[my_set] theorem ...adds a rewrite theorem@[my_set] def ...adds equation theorems from the definitionbuiltin_initialize symSimpExtensionregisters a default@[sym_simp]setgetSymSimpTheorems/getSymSimpExtension?retrieve theorem sets at tactic timeNew files:
Sym/Simp/Attr.lean: attribute logic (mkSymSimpAttr,registerSymSimpAttr)Sym/Simp/RegisterCommand.lean:register_sym_simp_attrmacroTests:
tests/pkg/sym_simp_attr/: package test with user-defined set (my_sym_simp)tests/elab/sym_simp_set.lean: tests for the builtin@[sym_simp]set