fix: grind fails to prove conjunction of independently provable goals#13024
Merged
leodemoura merged 1 commit intomasterfrom Mar 21, 2026
Merged
fix: grind fails to prove conjunction of independently provable goals#13024leodemoura merged 1 commit intomasterfrom
grind fails to prove conjunction of independently provable goals#13024leodemoura merged 1 commit intomasterfrom
Conversation
This PR fixes an issue where `grind` could prove each conjunct individually but failed on the conjunction. The root cause: `solverAction`'s `.propagated` path calls `processNewFacts` which drains the `newFacts` queue, but the resulting propagation cascade (congruence closure, or-propagation, `propagateForallPropDown`) can call `addNewRawFact`, enqueuing to the separate `newRawFacts` queue. These raw facts were never drained. The fix moves `Solvers.mkAction` to `Intro.lean` where it can compose the solver action with `assertAll`, unconditionally draining `newRawFacts` after every solver step. Closes #12581 Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR fixes an issue where
grindcould prove each conjunct individually but failed on the conjunction. The root cause:solverAction's.propagatedpath callsprocessNewFactswhich drains thenewFactsqueue, but the resulting propagation cascade (congruence closure, or-propagation,propagateForallPropDown) can calladdNewRawFact, enqueuing to the separatenewRawFactsqueue. These raw facts were never drained.The fix moves
Solvers.mkActionfromTypes.leantoIntro.leanwhere it can compose the core solver action withassertAll, unconditionally drainingnewRawFactsafter every solver step.Closes #12581