feat: add built-in sym_simproc and sym_discharger elaborators#13031
Merged
leodemoura merged 4 commits intomasterfrom Mar 22, 2026
Merged
feat: add built-in sym_simproc and sym_discharger elaborators#13031leodemoura merged 4 commits intomasterfrom
sym_simproc and sym_discharger elaborators#13031leodemoura merged 4 commits intomasterfrom
Conversation
This PR adds the built-in elaborators for the `sym_simproc` and `sym_discharger` DSL syntax categories introduced in #13026. Simproc elaborators (`@[builtin_sym_simproc]`): - `ground` → `evalGround` - `telescope` → `simpTelescope` - `self` → `simp` (recursive simplification) - `none` → identity (no simplification) - `rewrite setName [with discharger]` → named theorem set rewriting - `rewrite [thm₁, ...] [with discharger]` → inline theorem rewriting - `>>` → `andThen` combinator - `<|>` → `orElse` combinator Discharger elaborators (`@[builtin_sym_discharger]`): - `self` → `dischargeSimpSelf` - `none` → `dischargeNone` Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
Use syntax quotation patterns instead of raw `stx[i]` indexing. Add `elabOptDischarger` helper, remove `elabWithClause`. Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
Use `Lean.Parser.Sym.Simp.orElse` in the `@[builtin_sym_simproc]` attribute to avoid name resolution conflict where `orElse` resolves to a different syntax node kind. Add comprehensive DSL elaboration tests that go through the full pipeline: syntax → `elabSymSimproc`/`elabSymDischarger` → `Simproc`/`Discharger`. Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
leodemoura
added
changelog-language
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR adds the built-in elaborators for the
sym_simprocandsym_dischargerDSL syntax categories introduced in #13026.Simproc elaborators (
@[builtin_sym_simproc]):ground→evalGroundtelescope→simpTelescopeself→simp(recursive simplification)none→ identity (no simplification)rewrite setName [with discharger]→ named theorem set rewritingrewrite [thm₁, ...] [with discharger]→ inline theorem rewriting>>→andThencombinator<|>→orElsecombinatorDischarger elaborators (
@[builtin_sym_discharger]):self→dischargeSimpSelfnone→dischargeNoneNote:
orElserequires a fully-qualified attribute name (Lean.Parser.Sym.Simp.orElse) to avoid a name resolution conflict where the bareorElseresolves to a different syntax node kind.