fix: simp +arith and grind loop on normalized Int equalities#13033
Merged
leodemoura merged 2 commits intomasterfrom Mar 22, 2026
Merged
fix: simp +arith and grind loop on normalized Int equalities#13033leodemoura merged 2 commits intomasterfrom
simp +arith and grind loop on normalized Int equalities#13033leodemoura merged 2 commits intomasterfrom
Conversation
) This PR adds `r == e` guards to the `norm_eq_var` and `norm_eq_var_const` branches of `Int.Linear.simpEq?`. Without these guards, `simpEq?` returns a non-trivial proof for already-normalized equations like `x = -1`, causing `exists_prop_congr` to fire repeatedly and build an infinitely growing term. Closes #12812 Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
leodemoura
added
bug
Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR adds
r == eguards to thenorm_eq_varandnorm_eq_var_constbranches ofInt.Linear.simpEq?. Without these guards,simpEq?returns a non-trivial proof for already-normalized equations likex = -1, causingexists_prop_congrto fire repeatedly and build an infinitely growing term.The existing
Nat.simpCnstrPos?already had the equivalent guard (if r != lhs then ... else return none).Closes #12812