feat: add sanity checks to register_sym_simp#13040
Merged
leodemoura merged 1 commit intomasterfrom Mar 22, 2026
Merged
Conversation
This PR adds validation to the `register_sym_simp` command: - reject duplicate variant names - validate `pre`/`post` syntax by elaborating them via `elabSymSimproc` in a minimal `GrindTacticM` context, catching unknown theorem names and unknown theorem set references at registration time Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR adds validation to the
register_sym_simpcommand:pre/postsyntax by elaborating them viaelabSymSimprocin a minimal
GrindTacticMcontext, catching unknown theorem namesand unknown theorem set references at registration time
Adds
withGrindTacticMhelper for runningGrindTacticMfromCommandElabM,and
validateOptionSimprocSyntaxfor optional syntax validation.