fix: interaction of extern annotations and calls to functions with borrowed parameters#13052
Merged
fix: interaction of extern annotations and calls to functions with borrowed parameters#13052
Conversation
Contributor
Author
|
!bench |
|
Benchmark results for b3e83d2 against 189cea9 are in. There are no significant changes. @hargoniX
Medium changes (1✅)
Small changes (1✅, 2🟥)
|
b3e83d2 to
5a96d04
Compare
5a96d04 to
4a007bb
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR fixes a bug in the borrow inference in connection with
exportannotations.Previously parameters of
exportfunctions were presumed as owned from the beginning of theanalysis. However, they were not added into the set of owned parameters and thus sometimes failed to
force necessary changes to borrowedness of other values that the parameters flowed into.