feat: EquivBEq and LawfulHashable for String.Slice#13058
Merged
TwoFX merged 4 commits intoleanprover:masterfrom Mar 23, 2026
Merged
feat: EquivBEq and LawfulHashable for String.Slice#13058TwoFX merged 4 commits intoleanprover:masterfrom
EquivBEq and LawfulHashable for String.Slice#13058TwoFX merged 4 commits intoleanprover:masterfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR adds
EquivBEqandLawfulHashableinstances toString.Slice.To this end, we redefine
String.Slice.hash, which used to be completely opaque, to be defined asString.hash s.copy(and thenString.hashremains opaque). We add tests that thelean_slice_hashandlean_string_hashfunctions do indeed satisfy this relationship.Of course, it would be even better to have a streaming MurmurHash64A implementation in core that could be used to implement both of these so that we can avoid the
opaque, but that is a project for another day.