chore: revert @[mvcgen_witness_type] attribute (#12882)#13111
Merged
chore: revert @[mvcgen_witness_type] attribute (#12882)#13111
@[mvcgen_witness_type] attribute (#12882)#13111Conversation
sgraf812
changed the title
@[mvcgen_witness_type] attribute (#12882)@[mvcgen_witness_type] attribute (#12882)
sgraf812
force-pushed
the
worktree-revert-witness
branch
from
df26799 to
a137f85
Compare
sgraf812
removed
the
changelog-no
sgraf812
force-pushed
the
worktree-revert-witness
branch
from
a137f85 to
475f989
Compare
This PR removes the witness classification semantics from `mvcgen` introduced in #12882: the `@[mvcgen_witness_type]` attribute, `witnesses` field in `VCGen.State`, three-way goal classification, `elabWitnesses`, and `elabGoalSection`. The `witnesses` syntax section is kept temporarily for stage0 compatibility and will be removed in a follow-up PR after the stage0 update. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
sgraf812
force-pushed
the
worktree-revert-witness
branch
from
475f989 to
db4b509
Compare
github-actions
bot
added
the
toolchain-available
|
Mathlib CI status (docs):
|
Collaborator
|
Reference manual CI status:
|
sgraf812
added a commit
that referenced
this pull request
Mar 25, 2026
This PR removes the `witnessAlts` syntax section and related `witnessesKW` syntax that were kept for stage0 compatibility in #13111. Now that stage0 has been updated, the `mvcgen` syntax can use 5 children instead of 6. Also restores fixed `stx[3]`/`stx[4]` indexing in `elabMVCGen`. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
sgraf812
added a commit
that referenced
this pull request
Mar 26, 2026
This PR removes the `witnessAlts` syntax section and related `witnessesKW` syntax that were kept for stage0 compatibility in #13111. Now that stage0 has been updated, the `mvcgen` syntax can use 5 children instead of 6. Also restores fixed `stx[3]`/`stx[4]` indexing in `elabMVCGen`. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR reverts #12882 which added the
@[mvcgen_witness_type]tag attribute andwitnessessection tomvcgen. Théophile Wallez confirmed he doesn't need this feature and can get by withinvariants, so there is no use in having it.The actual
mvcgensyntax needs to be adjusted after a stage0 update in order forelabMVCGento cope with both old and new syntax.