perf: coalescing of RC ops within one basic block#13136
Merged
Conversation
Contributor
Author
|
!bench |
|
Benchmark results for 5cd1000 against a8bbc95 are in. Significant changes detected! @hargoniX
Large changes (2✅)
Medium changes (4✅)
Small changes (6✅, 1🟥)
|
|
Mathlib CI status (docs):
|
Collaborator
|
Reference manual CI status:
|
5cd1000 to
a7b6cb1
Compare
volodeyka
pushed a commit
that referenced
this pull request
Apr 16, 2026
This PR introduces coalescing of RC operations to the RC optimizer. Whenever we perform multiple `inc`s for a single value within one basic block it is legal to instead perform all of these `inc`s at once at the first `inc` side. This is the case because the value will stay alive until at least the last `inc` and was thus never observable with `RC=1`. Hence, this change of `inc` location never destroys reuse opportunities.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR introduces coalescing of RC operations to the RC optimizer. Whenever we perform multiple
incs for a single value within one basic block it is legal to instead perform all of theseincs at once at the firstincside. This is the case because the value will stay alive until at least the lastincand was thus never observable withRC=1. Hence, this change ofinclocation never destroys reuse opportunities.