feat: verification of String.dropWhile and String.takeWhile#13155
Draft
TwoFX wants to merge 1 commit intoleanprover:masterfrom
Draft
feat: verification of String.dropWhile and String.takeWhile#13155TwoFX wants to merge 1 commit intoleanprover:masterfrom
String.dropWhile and String.takeWhile#13155TwoFX wants to merge 1 commit intoleanprover:masterfrom
Conversation
|
Mathlib CI status (docs):
|
Collaborator
|
Reference manual CI status:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR verifies the
String.dropWhileandString.takeWhilefunctions.It also includes a refactor of the
PatternModelclass so that thenot_matches_emptycondition is moved into a separate typeclassStrictPatternModel. This allows string patterns to implementLawfulForwardPatternModelunconditionally, which means that more of the general theory about patterns directly applies to string patterns without having to do a case distinction for empty strings.This PR also includes a study of the
PatternModelmachinery given to slicessandtsuch thats.copy = t.copy. From these results, we deduce statements likes.copy.startsWith pat = s.startsWith pat(which is far from obvious!).TODOs:
TakeDrop/Basic.leanstill needs to be dualized todropEndWhile/takeEndWhileand friendsTODO: movecomments on displaced lemmas