fix: if _ : p ... syntax in new do elaborator#13192
Merged
Conversation
Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
sgraf812
force-pushed
the
sg/fix-dite-new-do
branch
from
a03a6c6 to
5d21b9e
Compare
github-actions
bot
added
the
toolchain-available
|
Mathlib CI status (docs):
|
Collaborator
|
Reference manual CI status:
|
volodeyka
pushed a commit
that referenced
this pull request
Apr 16, 2026
This PR fixes the handling of anonymous dependent `if` (`if _ : cond then ... else ...`) inside `do` blocks when using the new do elaborator. The `_%$tk` binder pattern was incorrectly quoted as `$(⟨tk⟩):hole` in the generated `dite` syntax, causing "elaboration function for `termDepIfThenElse` has not been implemented" errors. The fix quotes it correctly as `_%$tk`. A test case is added to verify both anonymous (`if _ : ...`) and named (`if h : ...`) dependent `if` work in do blocks. --------- Co-authored-by: Claude Opus 4.6 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR fixes the handling of anonymous dependent
if(if _ : cond then ... else ...) insidedoblocks when using the new do elaborator.The
_%$tkbinder pattern was incorrectly quoted as$(⟨tk⟩):holein the generatedditesyntax, causing "elaboration function fortermDepIfThenElsehas not been implemented" errors. The fix quotes it correctly as_%$tk.A test case is added to verify both anonymous (
if _ : ...) and named (if h : ...) dependentifwork in do blocks.