fix: make FirstTokens.seq (.optTokens _) .unknown return .unkown#13205
Merged
Conversation
github-actions
Bot
added
the
changelog-language
Member
|
!bench |
|
Benchmark results for 99a7d7f against 4786e08 are in. There are no significant changes. @Kha
No significant changes detected. |
volodeyka
pushed a commit
that referenced
this pull request
Apr 16, 2026
…13205) This PR fixes `FirstTokens.seq (.optTokens s) .unknown` to return `.unknown`. This occurs e.g. when an optional (with first tokens `.optTokens s`) is followed by a parser category (with first tokens `.unknown`). Previously `FirstTokens.seq` returned `.optTokens s`, ignoring the fact that the optional may be empty and then the parser category may have any first token. The correct behavior here is to return `.unknown`, which indicates that the first token may be anything. Closes #13203
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR fixes
FirstTokens.seq (.optTokens s) .unknownto return.unknown. This occurs e.g. when an optional (with first tokens.optTokens s) is followed by a parser category (with first tokens.unknown). PreviouslyFirstTokens.seqreturned.optTokens s, ignoring the fact that the optional may be empty and then the parser category may have any first token. The correct behavior here is to return.unknown, which indicates that the first token may be anything.Closes #13203