refactor: introduce LakefileConfig & well-formed workspaces#13282
Merged
tydeu merged 7 commits intoleanprover:masterfrom Apr 7, 2026
Merged
refactor: introduce LakefileConfig & well-formed workspaces#13282tydeu merged 7 commits intoleanprover:masterfrom
LakefileConfig & well-formed workspaces#13282tydeu merged 7 commits intoleanprover:masterfrom
Conversation
tydeu
force-pushed
the
lake/lakefile-config
branch
from
61b6177 to
a6c9693
Compare
github-actions
bot
added
the
toolchain-available
mathlib-nightly-testing bot
pushed a commit
to leanprover-community/batteries
that referenced
this pull request
Apr 5, 2026
github-actions
bot
added
the
mathlib4-nightly-available
mathlib-nightly-testing bot
pushed a commit
to leanprover-community/mathlib4-nightly-testing
that referenced
this pull request
Apr 5, 2026
leanprover-bot
added a commit
to leanprover/reference-manual
that referenced
this pull request
Apr 5, 2026
leanprover-bot
added
the
breaks-manual
Collaborator
|
Reference manual CI status:
|
mathlib-lean-pr-testing
bot
added
the
builds-mathlib
|
Mathlib CI status (docs):
|
volodeyka
pushed a commit
that referenced
this pull request
Apr 16, 2026
This PR introduces `LakefileConfig`, which can be constructed from a Lake configuration file without all the information required to construct a full `Package`. Also, workspaces now have a well-formedness property attached which ensures the workspace indices of its packages match their index in the workspace. Finally, the facet configuration map now has its own type: `FacetConfigMap`. Created by splitting off the major self-contained (but overlapping) refactors from #11662.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR introduces
LakefileConfig, which can be constructed from a Lake configuration file without all the information required to construct a fullPackage. Also, workspaces now have a well-formedness property attached which ensures the workspace indices of its packages match their index in the workspace. Finally, the facet configuration map now has its own type:FacetConfigMap.Created by splitting off the major self-contained (but overlapping) refactors from #11662.