Draft
Conversation
sgraf812
added
changelog-language
github-actions
bot
added
the
toolchain-available
Collaborator
|
Reference manual CI status:
|
mathlib-nightly-testing bot
pushed a commit
to leanprover-community/batteries
that referenced
this pull request
Apr 7, 2026
github-actions
bot
added
the
mathlib4-nightly-available
mathlib-nightly-testing bot
pushed a commit
to leanprover-community/mathlib4-nightly-testing
that referenced
this pull request
Apr 7, 2026
mathlib-lean-pr-testing
bot
added
the
breaks-mathlib
|
sgraf812
force-pushed
the
sg/new-do-rollout
branch
from
5a7028d to
3c523fd
Compare
Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
The pure continuation in `ControlLifter.lift` now uses a fresh result type `?α` instead of `l.origCont.resultType`, mirroring the legacy elaborator's `DoResultPR` pattern. This allows monad resolution to succeed independently of the expected result type. For example, `evalConstCheck Nat ``Nat name` in a `CoreM (Option Nat)` try/catch context: with `Option Nat` as expected type, Lean cannot decompose `?m Nat =?= CoreM (Option Nat)`, leaving `?m` stuck. With a fresh `?α`, Lean decomposes `?m Nat =?= CoreM ?α` successfully. The coercion from `?α` to the original result type is inserted by `mkPure` via `ensureHasType`. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
sgraf812
force-pushed
the
sg/new-do-rollout
branch
from
3c523fd to
951cc37
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR makes the new do elaborator the default, rolling it out into Mathlib and the rest of the ecosystem.