fix: generate SizeOf spec theorems for inductives with private constructors#13374
Merged
fix: generate SizeOf spec theorems for inductives with private constructors#13374
SizeOf spec theorems for inductives with private constructors#13374Conversation
…tructors This PR fixes `SizeOf` instance generation for public inductive types that have private constructors. The spec theorem proof construction needs to unfold `_sizeOf` helper functions which may not be exposed in the public view, so we use `withoutExporting` for the proof construction and type check. Closes #13373 Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
github-actions
bot
added
the
toolchain-available
Collaborator
|
Reference manual CI status:
|
mathlib-nightly-testing bot
pushed a commit
to leanprover-community/batteries
that referenced
this pull request
Apr 12, 2026
github-actions
bot
added
the
mathlib4-nightly-available
mathlib-nightly-testing bot
pushed a commit
to leanprover-community/mathlib4-nightly-testing
that referenced
this pull request
Apr 12, 2026
mathlib-lean-pr-testing
bot
added
the
builds-mathlib
|
Mathlib CI status (docs):
|
volodeyka
pushed a commit
that referenced
this pull request
Apr 16, 2026
…tructors (#13374) This PR fixes `SizeOf` instance generation for public inductive types that have private constructors. The spec theorem proof construction needs to unfold `_sizeOf` helper functions which may not be exposed in the public view, so we use `withoutExporting` for the proof construction and type check. Closes #13373 Co-authored-by: Claude Opus 4.6 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR fixes
SizeOfinstance generation for public inductive types that haveprivate constructors. The spec theorem proof construction needs to unfold
_sizeOfhelper functions which may not be exposed in the public view, sowe use
withoutExportingfor the proof construction and type check.Closes #13373