fix: include ignoreNoncomputable in LCNF cache key#13384
Merged
Conversation
This PR fixes a compiler panic when a structure constructor receives a noncomputable instance as an instance-implicit argument (leanprover#13371). The LCNF translation first visits the instance in an irrelevant position (type parameter) where `ignoreNoncomputable` is `true`, caches the result, and then reuses that cached entry in a relevant position, bypassing `checkComputable`. Adding `ignoreNoncomputable` to the cache key ensures the two contexts do not share cache entries.
Contributor
|
!bench |
|
Benchmark results for fd64d7a against 41ab492 are in. There are no significant changes. @hargoniX
Small changes (1🟥)
|
|
Benchmark results for fd64d7a against 41ab492 are in. There are no significant changes. @Kha
Small changes (1🟥)
|
hargoniX
approved these changes
Apr 13, 2026
This PR replaces the anonymous tuple cache key in LCNF translation with a named `CacheKey` structure, making the role of each field (including `ignoreNoncomputable`) explicit at construction sites.
github-actions
Bot
added
the
toolchain-available
Collaborator
|
Reference manual CI status:
|
mathlib-nightly-testing Bot
pushed a commit
to leanprover-community/batteries
that referenced
this pull request
Apr 13, 2026
github-actions
Bot
added
the
mathlib4-nightly-available
mathlib-nightly-testing Bot
pushed a commit
to leanprover-community/mathlib4-nightly-testing
that referenced
this pull request
Apr 13, 2026
mathlib-nightly-testing Bot
pushed a commit
to leanprover-community/batteries
that referenced
this pull request
Apr 13, 2026
mathlib-nightly-testing Bot
pushed a commit
to leanprover-community/mathlib4-nightly-testing
that referenced
this pull request
Apr 13, 2026
mathlib-lean-pr-testing
Bot
added
the
breaks-mathlib
|
Mathlib CI status (docs):
|
volodeyka
pushed a commit
that referenced
this pull request
Apr 16, 2026
This PR fixes a compiler panic when a structure constructor receives a noncomputable instance as an instance-implicit argument. The LCNF translation first visits the instance in an irrelevant position (type parameter) where `ignoreNoncomputable` is `true`, caches the result, and then reuses that cached entry in a relevant position, bypassing `checkComputable`. Adding `ignoreNoncomputable` to the cache key ensures the two contexts do not share cache entries. Fixes #13371
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR fixes a compiler panic when a structure constructor receives a noncomputable instance as an instance-implicit argument.
The LCNF translation first visits the instance in an irrelevant position (type parameter) where
ignoreNoncomputableistrue, caches the result, and then reuses that cached entry in a relevant position, bypassingcheckComputable. AddingignoreNoncomputableto the cache key ensures the two contexts do not share cache entries.Fixes #13371