feat: add internal skip do-element parser#13413
Merged
Merged
Conversation
This PR adds an internal `skip` syntax for do blocks, intended for use by the `if` and `unless` elaborators to replace `pure PUnit.unit` in implicit else branches. This gives the elaborator a dedicated syntax node to attach better error messages and location info to, rather than synthesizing `pure PUnit.unit` which leaks internal details into user-facing errors. Co-Authored-By: Rob23oba <robin.arnez@web.de>
sgraf812
force-pushed
the
sg/do-skip-parser
branch
from
c822f53 to
af390f8
Compare
github-actions
Bot
added
the
toolchain-available
|
Mathlib CI status (docs):
|
Collaborator
|
Reference manual CI status:
|
volodeyka
pushed a commit
that referenced
this pull request
Apr 16, 2026
This PR adds an internal `skip` syntax for do blocks, intended for use by the `if` and `unless` elaborators to replace `pure PUnit.unit` in implicit else branches. This gives the elaborator a dedicated syntax node to attach better error messages and location info to, rather than synthesizing `pure PUnit.unit` which leaks internal details into user-facing errors. Includes a stage0 trigger comment so that the new parser is available during bootstrapping. Co-authored-by: Rob23oba <robin.arnez@web.de>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR adds an internal
skipsyntax for do blocks, intended for use by theifandunlesselaborators to replacepure PUnit.unitin implicit else branches. This gives the elaborator a dedicated syntax node to attach better error messages and location info to, rather than synthesizingpure PUnit.unitwhich leaks internal details into user-facing errors.Includes a stage0 trigger comment so that the new parser is available during bootstrapping.