Skip to content

fix: two bugs in io.cpp#13427

Merged
hargoniX merged 1 commit into
masterfrom
hbv/fix_io
Apr 16, 2026
Merged

fix: two bugs in io.cpp#13427
hargoniX merged 1 commit into
masterfrom
hbv/fix_io

Conversation

@hargoniX
Copy link
Copy Markdown
Contributor

@hargoniX hargoniX commented Apr 16, 2026

This PR fixes two minor bugs in io.cpp:

  1. A resource leak in a Windows error path of Std.Time.Database.Windows.getNextTransition
  2. A buffer overrun in IO.appPath on linux when the executable is a symlink at max path length.

@hargoniX hargoniX added changelog-compiler Compiler, runtime, and FFI release-ci Enable all CI checks for a PR, like is done for releases labels Apr 16, 2026
@github-actions github-actions Bot added the toolchain-available A toolchain is available for this PR, at leanprover/lean4-pr-releases:pr-release-NNNN label Apr 16, 2026
@mathlib-lean-pr-testing
Copy link
Copy Markdown

mathlib-lean-pr-testing Bot commented Apr 16, 2026

Mathlib CI status (docs):

  • ❗ Batteries/Mathlib CI will not be attempted unless your PR branches off the nightly-with-mathlib branch. Try git rebase fed2f32651e1e24a507c12aae234ac59e4d9916a --onto d76e5a1886956bb38dc6bd2868260550dc66c309. You can force Mathlib CI using the force-mathlib-ci label. (2026-04-16 09:16:58)

@leanprover-bot
Copy link
Copy Markdown
Collaborator

leanprover-bot commented Apr 16, 2026 •
edited
Loading

Reference manual CI status:

  • ❗ Reference manual CI will not be attempted unless your PR branches off the nightly-with-manual branch. Try git rebase fed2f32651e1e24a507c12aae234ac59e4d9916a --onto 8156373037445edb7cbd8f804fc95919588733bd. You can force reference manual CI using the force-manual-ci label. (2026-04-16 09:17:00)
  • ✅ Reference manual branch lean-pr-testing-13427 has successfully built against this PR. (2026-04-16 12:52:26) View Log
  • 🟡 Reference manual branch lean-pr-testing-13427 build against this PR didn't complete normally. (2026-04-16 12:54:41) View Log

@hargoniX hargoniX enabled auto-merge April 16, 2026 11:56
@hargoniX hargoniX added this pull request to the merge queue Apr 16, 2026
mathlib-nightly-testing Bot pushed a commit to leanprover-community/batteries that referenced this pull request Apr 16, 2026
Update lean-toolchain for testing leanprover/lean4#13427
0c0a6c5
@github-actions github-actions Bot added the mathlib4-nightly-available A branch for this PR exists at leanprover-community/mathlib4-nightly-testing:lean-pr-testing-NNNN label Apr 16, 2026
mathlib-nightly-testing Bot pushed a commit to leanprover-community/mathlib4-nightly-testing that referenced this pull request Apr 16, 2026
Update lean-toolchain for testing leanprover/lean4#13427
e35ce50
leanprover-bot added a commit to leanprover/reference-manual that referenced this pull request Apr 16, 2026
@leanprover-bot
Update lean-toolchain for testing leanprover/lean4#13427
c4bdc11
@leanprover-bot leanprover-bot added the builds-manual CI has verified that the Lean Language Reference builds against this PR label Apr 16, 2026
Merged via the queue into master with commit 7e8a710 Apr 16, 2026
46 of 64 checks passed
@hargoniX hargoniX deleted the hbv/fix_io branch April 16, 2026 13:07
@mathlib-lean-pr-testing mathlib-lean-pr-testing Bot added the builds-mathlib CI has verified that Mathlib builds against this PR label Apr 16, 2026
@mathlib-lean-pr-testing
Copy link
Copy Markdown

mathlib-lean-pr-testing Bot commented Apr 16, 2026

Mathlib CI status (docs):

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

builds-manual CI has verified that the Lean Language Reference builds against this PR builds-mathlib CI has verified that Mathlib builds against this PR changelog-compiler Compiler, runtime, and FFI mathlib4-nightly-available A branch for this PR exists at leanprover-community/mathlib4-nightly-testing:lean-pr-testing-NNNN release-ci Enable all CI checks for a PR, like is done for releases toolchain-available A toolchain is available for this PR, at leanprover/lean4-pr-releases:pr-release-NNNN

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@hargoniX @leanprover-bot