feat: lake: add support for running text linters from lake lint#13513
Merged
wkrozowski merged 42 commits intoApr 28, 2026
Conversation
…Driver` is specified
Co-authored-by: Mac Malone <tydeu@hatpress.net>
Co-authored-by: Mac Malone <tydeu@hatpress.net>
Co-authored-by: Mac Malone <tydeu@hatpress.net>
Co-authored-by: Mac Malone <tydeu@hatpress.net>
Co-authored-by: Mac Malone <tydeu@hatpress.net>
Co-authored-by: Thomas R. Murrills <68410468+thorimur@users.noreply.github.com>
github-actions
Bot
added
the
toolchain-available
|
Mathlib CI status (docs):
|
Collaborator
|
Reference manual CI status:
|
tydeu
reviewed
Apr 23, 2026
tydeu
reviewed
Apr 23, 2026
Member
tydeu
left a comment
tydeu
left a comment
There was a problem hiding this comment.
Looking good! I have only one major concern, which is how extensive you want the rebuild to be (see my comment below).
tydeu
requested changes
Apr 25, 2026
Member
tydeu
left a comment
tydeu
left a comment
There was a problem hiding this comment.
The design looks good! Just a few more minor notes.
tydeu
approved these changes
Apr 28, 2026
wkrozowski
added a commit
to wkrozowski/lean4
that referenced
this pull request
Apr 29, 2026
This PR upstreams `dupNamespace` linter from batteries to work with new core environment linting framework, as a "clippy" linter - i.e. one that is not enabled by default. Stacked on top of leanprover#13513. --------- Co-authored-by: Mac Malone <tydeu@hatpress.net> Co-authored-by: Thomas R. Murrills <68410468+thorimur@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR extends
lake lint --builtin-lintto also support text linters (i.e. those usinglogLint/logLintIf), in addition to the environment linters added in #13431. Text-linter warnings emitted during the build are persisted into each module's.oleanvia a newLean.Linter.lintLogExtenvironment extension;lake lintre-runs the build for the target modules and reads the entries back, reporting them alongside the environment linter output.