fix: beta reduction in grind must respect generation threshold#13560
Merged
Conversation
Collaborator
|
Reference manual CI status:
|
|
Mathlib CI status (docs):
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR fixes a bug in
propagateBetaEqs(inLean.Meta.Tactic.Grind.Beta)where new equalities/terms introduced by beta reduction were added to the goal
without checking the generation threshold. The generation of the new fact
is the maximum generation of the lambda, the function
f, and itsarguments, plus one. Without the threshold check, beta reduction can
cascade indefinitely on self-similar lambdas such as
(fun b => f (b + 1)) = fun b => f b, which kept producingf n = f (n + 1)for everyn. The fix aggregates argument generationsbefore the threshold check and bails out when the resulting generation
reaches
maxGeneration.