fix: limit ring solver polynomial degree in grind#13585
Merged
Conversation
|
Mathlib CI status (docs):
|
Collaborator
|
Reference manual CI status:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR adds a
ringMaxDegreeconfiguration option (default1024) that bounds the maximum degree of polynomials processed by thegrindring solver. Equality constraints whose polynomial exceeds this threshold are discarded (with an issue reported once per goal), preventing pathological degree explosion on inputs such asr ^ (2 ^ 250 - 1).This PR also introduces
Poly.simpM?, a monadic version ofPoly.simp?built on the existing safe arithmetic primitives (mulMonM,combineM,mulConstM) inGrind.Arith.CommRing.SafePoly. The previous reflection-orientedPoly.simp?inSym.Arith.Polylacked the abort mechanisms needed during proof search, so the simplification path used byEqCnstrnow goes through the safe variant. A regression testtests/elab/grind_ring_degree_explosion.leanensuresgrindfails quickly on high-degree problems.