fix: distinguish recursive applications by source position#13645
Merged
Conversation
This PR fixes the termination checker reporting errors at the wrong recursive call site when a function contains structurally-identical recursive calls at different source locations. The `_recApp` `MData` attached to recursive applications carried the attached `Syntax`, but two structurally-equal `MData` wrappers could be merged by hashconsing/simplification, so the syntax of the first call ended up associated with both call sites. We now also store the source byte position as `_recAppPos`, which keeps the wrappers distinct. Closes #13444.
github-actions
Bot
added
the
toolchain-available
Collaborator
|
Reference manual CI status:
|
github-actions
Bot
added
the
mathlib4-nightly-available
mathlib-lean-pr-testing
Bot
added
the
builds-mathlib
|
Mathlib CI status (docs):
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR fixes the termination checker reporting errors at the wrong
recursive call site when a function contains structurally-identical
recursive calls at different source locations.
The
_recAppMDataattached to recursive applications carried theattached
Syntax, but two structurally-equalMDatawrappers could bemerged by hashconsing/simplification, so the syntax of the first call
ended up associated with both call sites. We now also store the source
byte position as
_recAppPos, which keeps the wrappers distinct.Closes #13444.