feat: improve diagnostiscs for grind local theorems#13698
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR improves the
grinddiagnostics output so that local hypotheses usedas E-matching theorems show up with their user-facing names and instantiation
counters, instead of being silently dropped or reported under an anonymous
local.<idx>identifier.Previously,
mkGlobalDiagfiltered theE-Matching instancestable down toorigins of the form
.decl declName, discarding every counter coming from alocal hypothesis (
.fvar,.local,.stx). Even when an origin was kept, thelocal-theorem path in
addLocalEMatchTheoremsonly recognizedeq_true hfora bare
h : fvarand fell back to a synthetic.local <idx>origin in allother cases, including the common one where the proof has been wrapped by an
Eq.mpcast.