Skip to content

feat: improve diagnostiscs for grind local theorems#13698

Merged
leodemoura merged 1 commit into
masterfrom
grind_gen_issue
May 10, 2026
Merged

feat: improve diagnostiscs for grind local theorems#13698
leodemoura merged 1 commit into
masterfrom
grind_gen_issue

Conversation

@leodemoura
Copy link
Copy Markdown
Member

@leodemoura leodemoura commented May 10, 2026

This PR improves the grind diagnostics output so that local hypotheses used
as E-matching theorems show up with their user-facing names and instantiation
counters, instead of being silently dropped or reported under an anonymous
local.<idx> identifier.

Previously, mkGlobalDiag filtered the E-Matching instances table down to
origins of the form .decl declName, discarding every counter coming from a
local hypothesis (.fvar, .local, .stx). Even when an origin was kept, the
local-theorem path in addLocalEMatchTheorems only recognized eq_true h for
a bare h : fvar and fell back to a synthetic .local <idx> origin in all
other cases, including the common one where the proof has been wrapped by an
Eq.mp cast.

@leodemoura leodemoura added the changelog-tactics User facing tactics label May 10, 2026
@leodemoura leodemoura enabled auto-merge May 10, 2026 23:25
@leodemoura leodemoura added this pull request to the merge queue May 10, 2026
Merged via the queue into master with commit 2674a13 May 10, 2026
23 of 25 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

changelog-tactics User facing tactics

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant