refactor: turn dupNamespace into a Lean.Linter#13708
Merged
Merged
Conversation
This PR moves the `dupNamespace` linter from the `EnvLinter` framework to the `Lean.Linter` (text linter) framework, matching how it is implemented in mathlib and batteries. The linter remains off-by-default and fires under `linter.extra` (or when explicitly enabled), so user-facing behavior is unchanged: namespaces duplicated consecutively in a declaration name still trigger a warning under `--extra`/`--lint-all`/`--lint-only dupNamespace`. The new implementation lives under `Lean.Linter.Extra.DupNamespace` and inspects declaration names harvested from `declRangeExt`, plus the alias names introduced by `export` statements. Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
wkrozowski
added
changelog-other
changelog-no
github-actions
Bot
added
the
toolchain-available
|
Mathlib CI status (docs):
|
Collaborator
|
Reference manual CI status:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR moves the
dupNamespacelinter from theEnvLinterframework to theLean.Linter(text linter) framework, upstreaming the code frommathlib.