feat: add newDecls fields to Core.State and Command.State#13731
Draft
wkrozowski wants to merge 3 commits into
Draft
feat: add newDecls fields to Core.State and Command.State#13731wkrozowski wants to merge 3 commits into
newDecls fields to Core.State and Command.State#13731wkrozowski wants to merge 3 commits into
Conversation
chore: thread `newDecls` chore: add getters chore: do not reset on `wrapAsyncAsSnapshot`
chore: add test
Contributor
Author
|
!bench |
|
Benchmark results for efa5c8f against 793cd14 are in. (These commits have already been benchmarked in a previous command.) No significant results found. @wkrozowski
Small changes (1✅, 4🟥)
|
Contributor
Author
|
!bench |
|
Benchmark results for efa5c8f against 793cd14 are in. (These commits have already been benchmarked in a previous command.) No significant results found. @wkrozowski
Small changes (1✅, 4🟥)
|
|
Mathlib CI status (docs):
|
Collaborator
|
Reference manual CI status:
|
nomeata
reviewed
May 14, 2026
Collaborator
nomeata
left a comment
There was a problem hiding this comment.
Does this work as expected in the presence of asynchronous elaboration? It seems this currently ignores declarations added asynchronously, but should it may block on that?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR adds
newDeclsfields toCore.StateandCommand.State, that is reseted every-time we elab a top-level command and is used to record newly added declarations to the environment. The primary goal of this change is to enableLean.Lintersto easily look-up newly added declarations and lint them.