refactor: dispatch try? builtins via @[builtin_try_tactic]#13766
Merged
Conversation
This PR moves the `evalSuggest` combinator and trace-handler dispatch from a hardcoded `match` on syntax kinds to the existing `tryTacticElabAttribute` registration mechanism, bringing `try?`'s extensibility model in line with normal tactics and interactive `grind`. Each built-in combinator (`<;>`, `first`, `paren`, `try`, `attempt_all`, `attempt_all_par`, `first_par`, `seq1`) and trace handler (`grind?`, `simp?`, `simp_all?`, `exact?`) is now registered as `@[builtin_try_tactic <kind>]`. `evalSuggestImpl` becomes a thin attribute-driven dispatcher mirroring `evalTactic`/`evalGrindTactic`. The post-run "no unsolved goals in terminal mode" check is no longer applied centrally by the dispatcher. Handlers that may leave goals open (`simp?`, `simp_all?`, the atomic fallback) call the new `checkTerminalGoals` helper themselves; handlers that close the goal by construction (`grind?`, `exact?`) and combinators that delegate via `evalSuggest` need no explicit call. Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
github-actions
Bot
added
the
toolchain-available
Collaborator
|
Reference manual CI status:
|
github-actions
Bot
added
the
mathlib4-nightly-available
mathlib-lean-pr-testing
Bot
added
the
builds-mathlib
|
Mathlib CI status (docs):
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR moves the
evalSuggestcombinator and trace-handler dispatchfrom a hardcoded
matchon syntax kinds to the existingtryTacticElabAttributeregistration mechanism, bringingtry?'sextensibility model in line with normal tactics and interactive
grind.Each built-in combinator (
<;>,first,paren,try,attempt_all,attempt_all_par,first_par,seq1) and trace handler (grind?,simp?,simp_all?,exact?) is now registered as@[builtin_try_tactic <kind>].evalSuggestImplbecomes a thinattribute-driven dispatcher mirroring
evalTactic/evalGrindTactic.The post-run "no unsolved goals in terminal mode" check is no longer
applied centrally by the dispatcher. Handlers that may leave goals
open (
simp?,simp_all?, the atomic fallback) call the newcheckTerminalGoalshelper themselves; handlers that close the goalby construction (
grind?,exact?) and combinators that delegate viaevalSuggestneed no explicit call.Co-Authored-By: Claude Opus 4.7 (1M context) noreply@anthropic.com