fix: include zetaUnused in Meta.Config cache key#13772
Merged
Merged
Conversation
github-actions
Bot
added
the
toolchain-available
Collaborator
|
Reference manual CI status:
|
github-actions
Bot
added
the
mathlib4-nightly-available
mathlib-lean-pr-testing
Bot
added
the
builds-mathlib
|
Mathlib CI status (docs):
|
This PR closes leanprover#13770 by including `Config.zetaUnused` in `Config.toKey`. Without this, two configs differing only in `zetaUnused` shared a `WHNF`/`isDefEq` cache key, so reductions performed under one setting could be returned for the other. Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
kim-em
force-pushed
the
fix-zetaUnused-cache-key
branch
from
b33cac7 to
520bf7c
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR closes #13770 by including
Config.zetaUnusedinConfig.toKey. Without this, two configs that differ only inzetaUnusedshare aWHNF/isDefEqcache key, so reductions performed under one setting can be returned for the other. The new bit sits at position 22, immediately abovezetaHave.🤖 Prepared with Claude Code