refactor: extract try? suggestions via TryThisInfo#13774
Merged
Conversation
This PR makes `try?`'s `expandUserTactic` walk the info tree for `TryThisInfo` nodes (introduced in #10524) instead of parsing the rendered `Try this:` message text. The previous approach scraped lines prefixed with ` [apply] ` from the message log, which would break the moment that wire format changed. The user tactic is run under `withSaveInfoContext` so the in-flight trees come out wrapped with a `PartialContextInfo.commandCtx`, which is what `InfoTree.foldInfo` needs in order to descend; the structured suggestions can then be read directly from the `TryThisInfo` nodes that `TryThis.addSuggestion` already pushes. The prior manual `Core.setMessageLog` save/restore dance is no longer needed. Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
github-actions
Bot
added
the
toolchain-available
Collaborator
|
Reference manual CI status:
|
github-actions
Bot
added
the
mathlib4-nightly-available
mathlib-lean-pr-testing
Bot
added
the
builds-mathlib
|
Mathlib CI status (docs):
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR makes
try?'sexpandUserTacticwalk the info tree forTryThisInfonodes (introduced in #10524) instead of parsing the rendered
Try this:messagetext. The previous approach scraped lines prefixed with
[apply]from themessage log, which would break the moment that wire format changed.
The user tactic is run under
withSaveInfoContextso the in-flight trees comeout wrapped with a
PartialContextInfo.commandCtx, which is whatInfoTree.foldInfoneeds in order to descend; the structured suggestions canthen be read directly from the
TryThisInfonodes thatTryThis.addSuggestionalready pushes. The prior manual
Core.setMessageLogsave/restore dance is nolonger needed.
Co-Authored-By: Claude Opus 4.7 (1M context) noreply@anthropic.com