perf: use MVarId.assign instead of isDefEq in type class search#13775
Draft
JovanGerb wants to merge 2 commits into
Draft
perf: use MVarId.assign instead of isDefEq in type class search#13775JovanGerb wants to merge 2 commits into
MVarId.assign instead of isDefEq in type class search#13775JovanGerb wants to merge 2 commits into
Conversation
Contributor
Author
|
!bench mathlib |
|
Benchmark results for leanprover-community/mathlib4-nightly-testing@a659c41 against leanprover-community/mathlib4-nightly-testing@70483db are in. There are significant results. @JovanGerb
No significant changes detected. |
github-actions
Bot
added
the
toolchain-available
Collaborator
|
Reference manual CI status:
|
mathlib-nightly-testing Bot
pushed a commit
to leanprover-community/batteries
that referenced
this pull request
May 19, 2026
github-actions
Bot
added
the
mathlib4-nightly-available
mathlib-lean-pr-testing
Bot
added
the
breaks-mathlib
|
Mathlib CI status (docs):
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR removes an
isDefEqcheck in type class synthesis that is redundant.Unfortunately, making this change breaks a few things in Mathlib, due to #9726, in combination with #9727.