Skip to content

chore: normalize URLs to the language reference in test results#7782

Merged
kim-em merged 1 commit intomasterfrom
normalize_language_reference_in_tests
Apr 2, 2025
Merged

chore: normalize URLs to the language reference in test results#7782
kim-em merged 1 commit intomasterfrom
normalize_language_reference_in_tests

Conversation

@kim-em
Copy link
Copy Markdown
Collaborator

@kim-em kim-em commented Apr 2, 2025

Links to the language reference include a version slug, either latest or v4.X.0. These are included in hovers, which then get tested. To avoid test breakages, in the testing framework we normalize all such URL prefixes back to REFERENCE.

@kim-em kim-em force-pushed the normalize_language_reference_in_tests branch 2 times, most recently from a0ab6f1 to 8005bc4 Compare April 2, 2025 01:06
@github-actions github-actions Bot temporarily deployed to lean-lang.org/lean4/doc April 2, 2025 01:13 Inactive
@github-actions github-actions Bot added the toolchain-available A toolchain is available for this PR, at leanprover/lean4-pr-releases:pr-release-NNNN label Apr 2, 2025
@ghost
Copy link
Copy Markdown

ghost commented Apr 2, 2025

Mathlib CI status (docs):

  • ❗ Batteries/Mathlib CI will not be attempted unless your PR branches off the nightly-with-mathlib branch. Try git rebase 2979830120f16453f7f7ff1259f22da4818a9f27 --onto 911ea07a73733650eefa5240652404856bdcceb7. You can force Mathlib CI using the force-mathlib-ci label. (2025-04-02 01:38:44)

@github-actions github-actions Bot temporarily deployed to lean-lang.org/lean4/doc April 2, 2025 01:44 Inactive
update tests

syntax

sigh

fix regex

allow rcs
@kim-em kim-em force-pushed the normalize_language_reference_in_tests branch from e2def36 to 742e510 Compare April 2, 2025 05:20
@github-actions github-actions Bot temporarily deployed to lean-lang.org/lean4/doc April 2, 2025 05:26 Inactive
@kim-em kim-em added this pull request to the merge queue Apr 2, 2025
Merged via the queue into master with commit 1ee7e1a Apr 2, 2025
16 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

toolchain-available A toolchain is available for this PR, at leanprover/lean4-pr-releases:pr-release-NNNN

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant