feat: add --ignore-missing flag to skip missing declarations#36
Merged
Conversation
1 task
hargoniX
requested changes
Jun 5, 2026
| modify (fun st => { st with noMDataExprs := {} }) | ||
| dumpConstant c | ||
| if (← get).ignoreMissing then | ||
| try dumpConstant c catch _ => pure () |
Contributor
There was a problem hiding this comment.
Why should ignoreMissing allow us to ignore any error that is thrown during constant dumping? Furthermore, which error that is not already handled by your changes in Export is handled by this?
Contributor
Author
There was a problem hiding this comment.
Indeed, thank you, I removed this change
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR adds a new command-line option,
--ignore-missing, to allow the exporter to skip missing constant lookups and proceed gracefully, rather than panicking.By default,
lean4exportstrictly panics when a constant requested for export is not present in the environment. In some systems, it is useful to query multiple declarations without knowing in advance if they are present in the environment.The main motivation for this option is the development of a disproof feature for
comparatorwhere a potentialtarget.disproofdeclaration might be present or not in the submitted solution.