Closed
Conversation
Rename executable root modules to be unique, as Lake now rejects duplicate root module names across executables (leanprover/lean4#13028). Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
- Remove @[run_builtin_parser_attribute_hooks] from meta parser (Verso.Method) - Add public meta import Init.System.FilePath for include_str (WebAssets) - Import Lean.PrettyPrinter.Delaborator.DeclWithSig for declSigWithId (PrettyPrint) - Split addAndCompile into addDecl/markMeta/compileDecl for attribute handlers that wrap meta definitions (Monad) - Use compiler.relaxedMetaCheck for signature definitions (Monad) - Add meta BEq Letter instance for Shrinkable compatibility (Arbitrary) Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
Keep `deriving BEq` for non-meta use and add a separate meta BEq instance for Shrinkable compatibility, with a comment explaining why. Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
The Plausible library is entirely meta, so Shrinkable/Arbitrary instances are meta and can't reference the non-meta derived BEq Letter. Instead of duplicating BEq, compare the underlying Char values directly. Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
Update plausible to get non-meta Shrinkable. The Shrinkable instances no longer need to be meta, but deriving BEq inside a public meta section still doesn't produce a meta instance (lean4 bug), so we add a manual meta BEq Letter alongside the derived one. Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
- Remove VersoDemoMain.lean and its lakefile target (already removed on nightly-testing, uses deleted APIs) - Inline `let decl` in attribute handlers to reduce diff vs original - Add comment explaining the saveSignature add/markMeta/compile dance Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
- Update expected TeX output for code-content-doc (whitespace changes)
- Disambiguate `{kw}` role for `where` which now matches multiple syntax
entries in v4.30 (Unif_hint and registerSymSimp)
- Update test project lake manifests
Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
kim-em
force-pushed
the
bump_to_v4.30.0-rc1
branch
from
c285207 to
3b6ad55
Compare
v4.30's `setStartOfFileLeading` expands the first token's leading whitespace to span from byte 0, which includes the padding whitespace that `parserInputString` prepends for position correctness. This caused highlighted code blocks to emit pages of whitespace before the actual code in TeX output. Setting `hasLeading := false` in ModuleParserState prevents `setStartOfFileLeading` from running, restoring correct behavior. Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
Contributor
|
Preview for this PR is ready! 🎉 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR bumps the Lean toolchain to v4.30.0-rc1.
Renames executable root modules to be unique, as Lake now rejects duplicate root module names across executables (leanprover/lean4#13028). Previously, multiple executables sharing
root :=Main`` with differentsrcDirvalues silently produced identical binaries.🤖 Prepared with Claude Code