-
Notifications
You must be signed in to change notification settings - Fork 0
Replace the yup validation library with zod #119
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Copilot reviewed 17 out of 18 changed files in this pull request and generated 1 comment.
Files not reviewed (1)
- package.json: Language not supported
Comments suppressed due to low confidence (1)
src/pages/Tasks/components/Form/tests/TaskForm.test.tsx:50
- The test title was updated from 'cancelled' to 'submitted', but verify that the test implementation actually simulates a submit action (and calls onSubmitSpy) rather than a cancel action.
it('should call onSubmit when submitted', async () => {
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Copilot reviewed 18 out of 19 changed files in this pull request and generated 2 comments.
Files not reviewed (1)
- package.json: Language not supported
📢 Instructions
🔧 Change Summary
Describe the changes included in this pull request. Link to the associated GitHub issue(s).
zodlibrary and removedyupyupwas used for validation such as forms and the ConfigProvider.yup.📝 Checklist
Pull request authors must complete the following tasks before marking the PR as ready to review.
🧪 Steps to Test
Describe the process to test the changes in this pull request.
View storybook and review the Form components.
Perform a full regression test of the application with specific focus on the sign in form and the task form, both edit and create tasks.
🔗 Additional Information
Optionally, provide additional details, screenshots, or URLs that may assist the reviewer.