Github standards initial commit #4
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mesaugat
reviewed
Jun 8, 2020
mesaugat
reviewed
Jun 8, 2020
mesaugat
reviewed
Jun 8, 2020
mesaugat
reviewed
Jun 8, 2020
mesaugat
reviewed
Jun 8, 2020
mesaugat
reviewed
Jun 8, 2020
mesaugat
reviewed
Jun 8, 2020
mesaugat
reviewed
Jun 8, 2020
mesaugat
reviewed
Jun 8, 2020
mesaugat
reviewed
Jun 8, 2020
mesaugat
reviewed
Jun 8, 2020
mesaugat
reviewed
Jun 8, 2020
|
|
||
| #### Best Practices: | ||
| * Pull Request should atleast be <b>reviewed by 1 person</b> before merging it to the base branch. | ||
| * Only comment author can resolve comment – if code was corrected or after discussion author decides to fix it. |
There was a problem hiding this comment.
This seems to be very strict. I think other team members should be able to resolve a comment too.
mesaugat
reviewed
Jun 8, 2020
mesaugat
reviewed
Jun 8, 2020
mesaugat
reviewed
Jun 8, 2020
mesaugat
reviewed
Jun 8, 2020
docs/git/smart_commit.md
Outdated
| * `#<transition-name>` : Moves the Jira issue to a particular workflow state. | ||
|
|
||
| eg: | ||
| * `git commit -m "TEST-34 #time 1w 2d 4h 30m Total work logged"`. |
There was a problem hiding this comment.
Let's make this succinct and let's try not to use TEST-34 as an example.
mesaugat
reviewed
Jun 8, 2020
mesaugat
reviewed
Jun 8, 2020
mesaugat
reviewed
Jun 8, 2020
mesaugat
approved these changes
Jun 22, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.