[Chore] Sprint 1 시연용 평면 자산 큐레이션#171
Merged
Merged
Conversation
- assets/demo-layouts/ 신설: bottleneck_hall, multi_exit_concourse, branched_corridor_office DXF 3종과 결정적 재생성 스크립트 추가. 세 평면은 결과 지표(피크 밀도, t90/t95, ExitUsage, ZoneCompletion)가 서로 다르게 나오도록 의도적으로 토폴로지를 구성. - docs/demo/시연 평면 가이드.md 추가: 평면별 시연 메시지와 강조 지표 정리. - tests/dxf/ 정리: 미활용 home_plan / apartment_floor_plan / evacuation_complex_large 와 cad-portfolio 라이선스 파일 제거. generate_building_samples.py 는 office_suite 만 생성하도록 트림. - tests/DxfImportServiceTests.cpp 에 신규 시연 DXF 3종의 임포트 회귀 가드 추가. - tests/ImportContractsTests.cpp 의 문자열 경로를 office_suite.dxf 로 교체. Refs: #168
Curating the demo layouts under assets/demo-layouts/ does not require removing the existing test fixtures contributed by another teammate. Keep the four DXF files and the LICENSE under tests/dxf/ so the provenance of the downloaded MIT sample is retained and the local generator can still reproduce the residential and evacuation samples. - Restore apartment_floor_plan.dxf, LICENSE.cad-portfolio.txt, home_plan.dxf, and evacuation_complex_large.dxf so existing attribution and regeneration paths stay intact. - Restore the build_home_plan and build_evacuation_complex_large helpers in generate_building_samples.py for the same reason. - Keep the new framing in tests/dxf/README.md (cross-reference to assets/demo-layouts/, and the row for blocking_review_demo.dxf that was previously undocumented) and combine it with the original provenance section that describes the kept files.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
assets/demo-layouts/에 추가docs/demo/시연 평면 가이드.md)tests/DxfImportServiceTests.cpp에 추가tests/dxf/README.md에assets/demo-layouts/분리 안내와 기존에 누락되어 있던blocking_review_demo.dxf행을 보강tests/ImportContractsTests.cpp의 정상 임포트 경로 픽스처를home_plan.dxf→office_suite.dxf로 정돈기존
tests/dxf/픽스처(apartment_floor_plan.dxf,LICENSE.cad-portfolio.txt,home_plan.dxf,evacuation_complex_large.dxf, generator 함수)는 다른 팀원의 기여라 그대로 보존합니다. 본 PR은 기여 보존을 전제로 시연 자산을 추가하는 데에만 책임을 둡니다.Related Issue
Area
Architecture Check
Verification
풀 앱 빌드까지 확인. `safecrowd_app.exe` (5MB) 및 `safecrowd_tests.exe` 모두 클린 빌드, `ctest` 1/1 passed.
PR CI 와 동일한 no-app 경로도 추가 확인:
Risks / Follow-up