[Engine] SystemScheduler phase 기반 시스템 실행 루프 구현#91
Merged
Conversation
- EngineWorld에 WorldQuery/WorldCommands 노출 추가 - EngineRuntime에 EcsCore, CommandBuffer, systems_ 소유권 추가 - addSystem, initialize, stepFrame 고정 스텝 루프 및 CommandBuffer flush 구현 - EngineRuntimeTests: 시스템 update 호출 및 CommandBuffer flush 검증 테스트 추가
- UpdatePhase, TriggerPolicy, SystemDescriptor 선언 - SystemScheduler: registerSystem(phase/order 정렬), configure, executePhase(phase 경계 flush) 구현 - EngineRuntime: systems_ 벡터를 SystemScheduler로 교체, addSystem에 descriptor 기본값 추가 - SystemSchedulerTests: phase 순서, order 정렬, phase 격리, flush 검증 (4개)
# Conflicts: # src/engine/EngineRuntime.cpp # src/engine/EngineRuntime.h # tests/EngineRuntimeTests.cpp
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
UpdatePhase열거형 선언:Startup,PreSimulation,FixedSimulation,PostSimulation,RenderSyncTriggerPolicy열거형 선언:EveryFrame,FixedStep,IntervalSystemDescriptor구조체:phase,order,triggerPolicy필드SystemScheduler구현: phase/order 정렬 삽입(registerSystem), 전체 시스템configure, phase 경계CommandBuffer::flush포함 실행(executePhase)EngineRuntime:systems_벡터를SystemScheduler로 교체,addSystem에 기본값FixedSimulationdescriptor 추가로 기존 테스트 호환 유지SystemSchedulerTests추가: phase 순서, order 정렬, phase 격리, flush 반영 검증 (4개)Related Issue
Area
Architecture Check
application -> domain -> engine.src/domain.domainorapplicationdependencies tosrc/engine.src/as the include root.Verification
cmake --preset windows-debug-no-appcmake --build --preset build-no-app-debugctest --preset test-no-app-debugwindows-debug-no-app/build-no-app-debug/test-no-app-debugpreset 기준 실행 — configure, build, test(1/1) 모두 통과.Risks / Follow-up
before/after의존성 제약(위상 정렬)은 미구현 — 필요 시 별도 이슈로 확장 가능TriggerPolicy::Interval정책 완전 구현 미완 — 현재는 열거형만 선언feat/issue-12로 설정 — Task-Implement EngineRuntime minimal orchestration API #12 머지 후main으로 리베이스 필요