Add course unit view#14128
Open
AlexVelezLl wants to merge 3 commits intolearningequality:release-v0.19.xfrom
Open
Add course unit view#14128AlexVelezLl wants to merge 3 commits intolearningequality:release-v0.19.xfrom
AlexVelezLl wants to merge 3 commits intolearningequality:release-v0.19.xfrom
Conversation
Contributor
Build Artifacts
|
8ad48af to
85f6c68
Compare
rtibbles
requested changes
Feb 6, 2026
Member
rtibbles
left a comment
There was a problem hiding this comment.
Changes broadly make sense from a quick review - the only blocker that stands out is the incorrect assumption about where the pre and post test data live. It's on the unit itself!
Also OK to just remove this here and leave implementation of this part to #14134
| return currentLessons.value?.find(lesson => lesson.id === props.lessonId); | ||
| }); | ||
|
|
||
| const currentResource = computed(() => { |
Member
There was a problem hiding this comment.
This is how they appear in the side panel - but not how they're actually represented in the DB - the pre/post-tests are only specified/attached on the Unit ContentNode itself.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Route setup and CourseUnitView shell component.
References
Closes #14071
Reviewer guidance
Go to
/learn/#/home/course/{course_id}/u/{unit_id}/l/{lesson_id}/r/{resource_id}and check that the shell looks fine.